Skip to content

Conversation

@einat-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@einat-starkware einat-starkware marked this pull request as ready for review January 12, 2026 08:54
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @einat-starkware and @noaov1).


crates/apollo_http_server/src/http_server_test.rs line 304 at r1 (raw file):

//     let starknet_error = serde_json::from_str::<StarknetError>(&serialized_err).unwrap();
//     assert_eq!(starknet_error, expected_err);
// }

Instate of commenting add #[ignore] + TODO

Suggestion:

// TODO(Einat): turn test back on when port issue is fixed.
#[ignore] 
// #[rstest]
// #[case::missing_version(
//     0,
//     None,
//     StarknetError {
//         code: StarknetErrorCode::KnownErrorCode(KnownStarknetErrorCode::MalformedRequest),
//         message: "Missing version field".to_string(),
//     }
// )]
// #[case::bad_version(
//     1,
//     Some("bad version"),
//     StarknetError {
//         code: StarknetErrorCode::KnownErrorCode(KnownStarknetErrorCode::MalformedRequest),
//         message: "Version field is not a valid hex string: badversion".to_string(), //Note:
// whitespaces are removed when parsing malformed tx jsons     }
// )]
// #[case::old_version(2, Some("0x1"), StarknetError {
//             code: StarknetErrorCode::KnownErrorCode(
//                 KnownStarknetErrorCode::InvalidTransactionVersion,
//             ),
//             message: "Transaction version 1 is not supported. Supported versions: [3]."
//                 .to_string(),
//         },
// )]
// #[case::newer_version(3, Some("0x4"), StarknetError {
//                 code: StarknetErrorCode::KnownErrorCode(
//                     KnownStarknetErrorCode::InvalidTransactionVersion,
//                 ),
//                 message: "Transaction version 4 is not supported. Supported versions: [3]."
//                     .to_string(),
//             }
// )]
// #[tokio::test]
// async fn test_unsupported_tx_version(
//     #[case] index: u16,
//     #[case] version: Option<&str>,
//     #[case] expected_err: StarknetError,
// ) {
//     // Set the tx version to the given version.
//     let mut tx_json =
//         TransactionSerialization(serde_json::to_value(deprecated_gateway_invoke_tx()).unwrap());
//     let as_object = tx_json.0.as_object_mut().unwrap();
//     if let Some(version) = version {
//         as_object.insert("version".to_string(), Value::String(version.to_string())).unwrap();
//     } else {
//         as_object.remove("version").unwrap();
//     }

//     let mock_gateway_client = MockGatewayClient::new();
//     let mock_config_manager_client = MockConfigManagerClient::new();

//     let http_client =
//         add_tx_http_client(mock_config_manager_client, mock_gateway_client, 9 + index).await;

//     let serialized_err =
//         http_client.assert_add_tx_error(tx_json, reqwest::StatusCode::BAD_REQUEST).await;
//     let starknet_error = serde_json::from_str::<StarknetError>(&serialized_err).unwrap();
//     assert_eq!(starknet_error, expected_err);
// }

Copy link
Contributor Author

@einat-starkware einat-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@einat-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1).


crates/apollo_http_server/src/http_server_test.rs line 304 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Instate of commenting add #[ignore] + TODO

Done.

Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1).

@einat-starkware einat-starkware added this pull request to the merge queue Jan 12, 2026
Merged via the queue into main with commit 2a5c562 Jan 12, 2026
20 of 29 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2026
@einat-starkware einat-starkware deleted the einat/turn_off_http_test branch January 20, 2026 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants